This is the method I want to test. In this test method (test_get_all_products), I want to pass in a list of products and a mocked response for the DB call which is identified by dal.
def get_all_user_standalone_products(all_products, dal):
standalone_products = []
if all_products is not None:
all_products = all_products['userRenewableProduct']
for product in all_products:
sku_id = product.get('skuID', 0)
sku_cost_id = product.get('skuCostID', 0)
standalone_product = which_standalone_product(sku_id)
if product.get('isDisabled') or standalone_product is None:
continue
product['productType'] = standalone_product['name']
sku_cost_data = dal.skucosts.get_costs_for_sku_cost_id(
sku_cost_id)
product['termMonths'] = sku_cost_data['termMonths']
upgrade_sku_ids = standalone_product.get(
'upgrade_sku_ids', [])
if len(upgrade_sku_ids) > 0:
product['canUpgrade'] = True
product['upgradeSkus'] = upgrade_sku_ids
standalone_products.append(product)
return standalone_products
This is my test
product_sku_cost= {
u'testPriceSetID':u'',
u'skuID':88,
u'currencyTypeID':1,
u'termMonths':1,
u'dateCreated': u'2015-10-07T17:03:00 Z',
u'skuCostID':2840,
u'cost':9900,
u'skuTypeID':13,
u'dateModified': u'2015-10-07T17:03:00 Z',
u'isDefault':True,
u'name':u'Product'}
@patch('model.dal')
def test_get_all_products(self, dal):
# this is my mock - I want it to return the dictionary above.
dal.SKUCosts.get_costs_for_sku_cost_id.return_value = product_sku_cost
products = get_all_user_standalone_products(renewable_products, dal)
assert products[0]['canUpgrade'] is True
assert products[0]['termMonths'] == 1
But when I assert the products[0]['termMonths'] == 1 which comes from the mocked object, it fails because the termMonths is actually the Mock object itself, not the return value(product_sku_cost) I was expecting.
Please help me figure out what I am doing incorrectly above.
It is just a TYPO error: try to change SKUCost
to skucost
where you configured dal
. So configuration line become:
dal.skucsts.get_costs_for_sku_cost_id.return_value = product_sku_cost
Anyway there is some other issues in your test: You don't need to patch anything in your test because you're passing dal
object and nothing use model.dal
reference. I don't know what model.dal
but if what you want to do is to have the same signature/properties you can use create_autospec
to build it.
Your test can be:
def test_get_all_products(self, dal):
# this is my mock - I want it to return the dictionary above.
dal = create_autospec(model.dal)
dal.skucosts.get_costs_for_sku_cost_id.return_value = product_sku_cost
...
If model.dal
is a class use instance=True
when you create autospec.
Collected from the Internet
Please contact [email protected] to delete if infringement.
Comments