Rails Model method check if field nil, if so return empty string

debugcn Published at Dev

Chris Valentine

In my model class I have a method:

def full_address
    address_lines = [self.address1,self.address2,self.address3].reject!(&:empty?).join(',')
    fulladdress = address_lines + ", " + self.city + ', ' + self.state  + ', ' + self.zipcode
    return fulladdress 
end

This is just an easy way to return all the address fields to view them quickly.

This returns undefined method 'empty?' for nil:NilClasswhen its empty. How can I change the method to work if all address1, address2, address3 are empty?

I guess I'm looking for a function like:

ReturnBlankIfNilElseValue(self.address1)

Anything like that exist?

def full_address
    address_lines = [self.address1.to_s,self.address2.to_s,self.address3.to_s].reject!(&:empty?).join(',')
    fulladdress = address_lines + ", " + self.city + ', ' + self.state  + ', ' + self.zipcode
    return fulladdress 
end

This variation returns no implicit conversion of nil into String which is odd because in rails console i can type nil.to_s and get an empty string.

I don't really want to check if each field is nil and then add to the array, i'd prefer a function that just returned empty string if it is nil.

Sorry the nil.to_s does work its the 2nd line that needed one as well. Its working now will get rid of this.

Myst

You can, although this might not be what you wanted, simply remove any nil objects from the address Array using the #compact method, so that #empty? will work...:

def full_address
    [self.address1, self.address2, self.address3,
        self.city, self.state, self.zipcode].compact.reject!(&:empty?).join(', ')
end

You should be aware that this WILL return a partial address if SOME of the fields exist.

I would probably void any fault addresses (in this example I require just the first address line and the city fields):

def full_address
    return "" unless self.address1 && self.city && !self.address1.empty? && !self.city.empty? 
    [self.address1, self.address2, self.address3,
        self.city, self.state, self.zipcode].compact.reject!(&:empty?).join(', ')
end

Disregarding the few edits I made to the code, I would probably go with @Joseph's #present? together with the validation, since you're using Rails:

def full_address
    return "" unless self.address1 && self.city && self.address1.present? && self.city.present? 
    [self.address1, self.address2, self.address3,
        self.city, self.state, self.zipcode].reject!(&:present?).join(', ')
end

Collected from the Internet

Please contact [email protected] to delete if infringement.

edited at2021-07-8

Comments

0 comments

From Dev

Related Related

Article

Rails Model method check if field nil, if so return empty string

Rails Model method check if field nil, if so return empty string

Rails check if model is empty

Check if not nil and not empty in Rails shortcut?

Rails active model serializer, how to return empty string instead of null

Rails active model serializer, how to return empty string instead of null

Should Ruby method return nil or empty object

Rails define nil check on record in model

rails accessing model attributes return nil

rails text_field / text_ara empty string vs nil

Check if a string isn't nil or empty in Lua

undefined method `[]' for nil:NilClass for Rails model on new

undefined method `[]' for nil:NilClass for Rails model on new

return a default value for empty field on a django model

Using Rails model method to fetch and return value

Rails 4: model.where.not does not return nil records

Is the empty string a legal field/method name?

Why does NSDateFormatter not return nil when given empty string ("")

Why does NSDateFormatter not return nil when given empty string ("")

Why does my new class method in a Rails model result in nil?

Rails undefined method 'model_name' for nil:nilClass with nested attributes

Rails simple form undefined method `model_name' for nil:NilClass

Rails: undefined method `model_name' for nil:NilClass

Rails simple form undefined method `model_name' for nil:NilClass

Rails - NoMethodError: undefined method `each' for nil:NilClass on Model.find_by

Rails 4.1 tests return undefined method `authenticate' for nil:NilClass

Rails: return capitalized string from model

Check if input field value exist in array, if so return to page with an error

Check a recordset for an empty field

Check if BCC field is empty

Check if calendar field is empty