Efficient loop code? Also, a query about the "for each" loop
user2911290
The following code compiles and does what I require. It iterates through an int-based multidimensional array (called nums), and searches for all occurances of the value 1. This program's output is shown below. There are three things to note:
- Regarding the "outer for" loop statement, I have used Java's comma operator to declare two additional variables.
- Also regarding this "outer for", I've used another comma operator in the "iteration section", to reset one of these additional variables.
- Regarding the "inner for", I've used another comma operator in the "iteration section" to increment this additional variable.
int[][] nums = {{1,1,2},{3,4},{5},{6,7,8},{9,1,1}};
for (int i=0, elsSearched=0, foundCount=0; i < nums.length; i++, elsSearched=0) {
for (int j=0; j < nums[i].length; j++, elsSearched++) {
if (nums[i][j] == 1) {
foundCount++;
}
}
System.out.println("Searched " + elsSearched +
" elements, and found \'number one\' a total of " + foundCount + " times..");
}
Program output:
Could this code be written more effeciently/elegantly?
My other query is about Java's "for each" loop. I tried rewritting the code above using the "for each" loop with the comma operator, but the code wouldn't compile. I quickly came to the obvious conclusion, but would the "for each" loop be better if the comma operator could be used with it, or would that just introduce "distracting clutter"?
jmiserez
Edit: Be aware that foundCount is the total number of elements found up until now, as it is never reset to zero. Was this intended?
Don't you agree that this code is easier to read and more concise? (Note: efficiency is the same as your code)
int[][] nums = {{1,1,2},{3,4},{5},{6,7,8},{9,1,1}};
int foundCount = 0;
for(int[] inner : nums){
for(int i : inner){
if (i == 1){
foundCount++;
}
}
System.out.println("Searched " + inner.length +
" elements, and found \'number one\' a total of " + foundCount + " times..");
}
Output:
Searched 3 elements, and found 'number one' a total of 2 times..
Searched 2 elements, and found 'number one' a total of 2 times..
Searched 1 elements, and found 'number one' a total of 2 times..
Searched 3 elements, and found 'number one' a total of 2 times..
Searched 3 elements, and found 'number one' a total of 4 times..
Collected from the Internet
Please contact [email protected] to delete if infringement.
edited at
- Prev: Reading a POP3 message via JavaMail returns only the trailing period, not the content
- Next: C++ binary search with char array
Related
Related Related
- 1
Efficient loop code? Also, a query about the "for each" loop
- 2
Python Sqlalchemy: Efficient Query and For Loop
- 3
SQL - For Each loop in a query
- 4
How to avoid doing a query each time loop runs? (optimize code)
- 5
Replace This While Loop with More Efficient Code?
- 6
Question about simplifying code related to loop iteration
- 7
Running a loop for each mysql query result fields
- 8
Trying to use a Query each loop on Raphael object
- 9
Loop through CTE results and run a query for each
- 10
My loop code on jquery doesn't work with .each inside the loop
- 11
vbscript for each loop to for loop
- 12
jQuery loop / .each function to simplify code
- 13
VBA For Each Loop to Excel JavaScript API Code
- 14
Ruby On Rails, code in each loop in view
- 15
jQuery loop / .each function to simplify code
- 16
Parse cloud code delay each iteraton of for loop
- 17
How can one improve this code with a loop so that it is much shorter and efficient?
- 18
Efficient alternative to for loop of ifelse
- 19
Energy efficient spin loop
- 20
efficient loop in R
- 21
Efficient loop multithreading
- 22
efficient vectorizisation of a double for loop
- 23
JOGL efficient render loop
- 24
Making loop more efficient
- 25
Efficient alternative to for loop of ifelse
- 26
Making loop more efficient
- 27
React Native Set State not a function, in a for each loop not sure about binding?
- 28
I have a question about the while loop in my code
- 29
regexp loop to find first instance of each query TCL
Comments