重载矩阵乘法“ *”运算符有问题

Xiyang Liu

对于长期以来提出的问题,我深表歉意,这只是我第二次使用此网站。在不久的将来,我将确保我的问题得到有条不紊的综合。

我正在写一个包含重载乘法的by m矩阵类。目前,仅当第一个输入矩阵的列与第二个矩阵的行匹配时,代码才对n×n和n×m矩阵乘法起作用。因此,例如:

a1 a2 * b1
        b2

这将起作用(对不起,我没有足够的信誉度来发布图像,但是可以将其视为1x2矩阵* 2x1矩阵)。

a1 * b1 b2
a2

但是这种类型的输入不起作用。

我的矩阵类由下式给出:

#include<iostream>
#include <stdlib.h>
using namespace std;
class dymatrix
{
    friend ostream & operator << (ostream &os, const dymatrix &om);
    friend istream & operator >> (istream &is, dymatrix &om);
private:
    int rows;
    int columns;
    double *matrix;
public:
    dymatrix(){cout<<"Default constructor called"<<endl; columns = 0; rows=0; matrix=0;}
    ~dymatrix(){cout<<"Destructor called"<<endl;delete[] matrix;}  
    dymatrix(int inrows, int incolumns) //Parametrised objects, matrix database is defined here to store data.
    {
        rows = inrows;
        columns = incolumns;
        matrix = new double [inrows*incolumns];
        for (int i=0; i<inrows*incolumns; i++) 
        { 
            matrix[i]=0;
        }
    }
    int lengthr() const {return rows;}  //Returns number of rows.
    int lengthc() const {return columns;}   //Return number of columns.
    dymatrix &operator=( dymatrix &arr); //This is the assignment member function.
    dymatrix(dymatrix&);    //This is the deep copy member function.
    dymatrix operator*(const dymatrix& arr)const ;  //Overloading "*" operator.

    double & operator[](const int n)    //Overloading "[]" operator, this is important !!!
    {
        if(n<0 || n>=rows*columns)
        {
            cout<<"Error: trying to access matrix element out of bounds"<<endl;
            exit(1);
        }
    return matrix[n];
    }
    int index(int j, int i) const //This member function returns the position of each index.
    {
        if (j > 0 && j <=rows && i > 0 && i <=columns)
        {
        //cout<<"i is "<<i<<" j is "<<j<<endl<<endl<<"row is "<<rows<<" columns is "<<columns<<endl;
            return (i-1)+(j-1)*columns;
        }
        else {cout<<"Error, out of range"<<endl<<"i is "<<i<<" j is "<<j<<endl<<endl<<"row is "<<rows<<" columns is "<<columns<<endl; exit (1);}
    }
    double & operator()(int j, int i) const {return matrix[index(j,i)];} //The operator () returns the position of j and i in 1D array.
    }; //Class End.

其中“ index ”成员函数将矩阵内每个元素的位置返回到一维数组中:

int index(int j, int i) const //This member function returns the position of each index.
    {
        if (j > 0 && j <=rows && i > 0 && i <=columns)
        {
        //cout<<"i is "<<i<<" j is "<<j<<endl<<endl<<"row is "<<rows<<" columns is "<<columns<<endl;
            return (i-1)+(j-1)*columns;
        }
        else {cout<<"Error, out of range"<<endl<<"i is "<<i<<" j is "<<j<<endl<<endl<<"row is "<<rows<<" columns is "<<columns<<endl; exit (1);}
    }
    double & operator()(int j, int i) const {return matrix[index(j,i)];}  //The operator () returns the position of j and i in 1D array.

这是我在课外重载乘法“ *”运算符的部分

dymatrix dymatrix:: operator * (const dymatrix &arr) const //Overloading "*" operator.
{
    if (columns != arr.rows)
    {
        cerr<<"SIZE DO NOT MATCH, YOU FAIL"<<endl; exit(1);
    }
    dymatrix new_matrix(rows,arr.columns);
    for (int j = 1; j <= rows; j++)
    {
        for (int i = 1; i <= arr.columns; i++)
        {
            for (int k = 1; k <= columns; k++)
            {
                new_matrix.matrix[index(j,i)]= new_matrix.matrix[index(j,i)]+ matrix[index(j,k)]*arr(k,i);
                cout<<"new_matrix = "<<new_matrix<<endl<<endl;
            }
        }
    }
    return new_matrix;
}

这里给出了int main:

int main()
{
    dymatrix a1;
    cin >> a1;  //Define the rows of the matrix
    cout << a1<<endl<<endl;
    dymatrix a2;
    cin >> a2;
    cout << a2<<endl<<endl;
    dymatrix resu_a3;
    resu_a3 = a1*a2;
    cout<<"Multiplication = "<<resu_a3<<endl;
    return 0;
}

因此,我在运行代码后收到的错误消息是我在“ index ”成员函数中编写的错误消息

“错误,超出范围”。

该错误消息表明i和j分别小于0或大于现有的列和行的数量,我不明白为什么会是这种情况。

我的完整代码在这里给出:

#include<iostream>
#include <stdlib.h>
using namespace std;
class dymatrix
{
    friend ostream & operator << (ostream &os, const dymatrix &om);
    friend istream & operator >> (istream &is, dymatrix &om);
private:
    int rows;
    int columns;
    double *matrix;
public:
    dymatrix(){cout<<"Default constructor called"<<endl; columns = 0; rows=0; matrix=0;}
    ~dymatrix(){cout<<"Destructor called"<<endl;delete[] matrix;}  
    dymatrix(int inrows, int incolumns) //Parametrised objects, matrix database is defined here to store data.
    {
        rows = inrows;
        columns = incolumns;
        matrix = new double [inrows*incolumns];
        for (int i=0; i<inrows*incolumns; i++) 
        { 
            matrix[i]=0;
        }
    }
    int lengthr() const {return rows;}  //Returns number of rows.
    int lengthc() const {return columns;}   //Return number of columns.
    dymatrix &operator=( dymatrix &arr); //This is the assignment member function.
    dymatrix(dymatrix&);    //This is the deep copy member function.
    dymatrix operator*(const dymatrix& arr)const ;  //Overloading "*" operator.

    double & operator[](const int n)    //Overloading "[]" operator, this is important !!!
    {
        if(n<0 || n>=rows*columns)
        {
            cout<<"Error: trying to access matrix element out of bounds"<<endl;
            exit(1);
        }
    return matrix[n];
    }
    int index(int j, int i) const //This member function returns the position of each index.
    {
        if (j > 0 && j <=rows && i > 0 && i <=columns)
        {
        //cout<<"i is "<<i<<" j is "<<j<<endl<<endl<<"row is "<<rows<<" columns is "<<columns<<endl;
            return (i-1)+(j-1)*columns;
        }
        else {cout<<"Error, out of range"<<endl<<"i is "<<i<<" j is "<<j<<endl<<endl<<"row is "<<rows<<" columns is "<<columns<<endl; exit (1);}
    }
    double & operator()(int j, int i) const {return matrix[index(j,i)];} //The operator () returns the position of j and i in 1D array.
}; //Class End.
    dymatrix::dymatrix(dymatrix &arr)   //This is the copy constructor for deep copying.
    {
        matrix = 0; rows = arr.lengthr(); columns = arr.lengthc();
        if (rows*columns >0)
        {
            matrix = new double [rows*columns];
            for (int i =0; i < rows*columns; i++) 
            {
                matrix[i] = arr[i];
            }
        }
    }
    dymatrix & dymatrix ::operator = (dymatrix &arr)
    {
        if(&arr == this) return *this; // no self assignment
        delete[] matrix; matrix=0; rows=columns=0;
        rows=arr.lengthr();
        columns = arr.lengthc();
        if(rows*columns>0)
         {
            matrix=new double[rows*columns];
            // Copy values into new array
            for(int i=0;i<rows*columns;i++) matrix[i] = arr[i];
        }
    return *this; // Special pointer!!
    }
    istream & operator >> (istream &is, dymatrix &om)   //Overloading ">>" operator here to
    {
        cout<<"Please enter the number of rows you want"<<endl;
        is >> om.rows;  //Inputting number of rows.
        cout<<"Enter the number of columns you want"<<endl;
        is >> om.columns;   //Inputting number of columns.
        cout<<"Enter matrix"<<endl;
        om.matrix = new double [om.rows*om.columns];    //Making a dynamic array here to put the data in.
        for (int j = 1; j <= om.rows; j++)
        {
            for (int i = 1; i <= om.columns; i++)
            {
                is >> om.matrix[om.index(j,i)]; //Putting in the data into this dynamic array for each element.
            }
        }
        return is;
    }
    ostream & operator << (ostream &os, const dymatrix &om)  //To output the matrix in an standard matrix way
    {
        for(int j= 1; j<=om.rows; j++)
        {
            os<<endl<<endl;
            for (int i = 1; i <=om.columns;i++)
            {
                os << om.matrix[om.index(j,i)]<<"\t";   //Similar method used in istream.
            }
        }
        return os;
    }

    dymatrix dymatrix:: operator * (const dymatrix &arr) const //Overloading "*" operator.
    {
        if (columns != arr.rows)
        {
            cerr<<"SIZE DO NOT MATCH, YOU FAIL"<<endl; exit(1);
        }
        dymatrix new_matrix(rows,arr.columns);
        for (int j = 1; j <= rows; j++)
        {
            for (int i = 1; i <= arr.columns; i++)
            {
                for (int k = 1; k <= columns; k++)
                {
                    new_matrix.matrix[index(j,i)]= new_matrix.matrix[index(j,i)]+ matrix[index(j,k)]*arr(k,i);
                    cout<<"new_matrix = "<<new_matrix<<endl<<endl;
                    cout<<"k "<<k<<endl<<" arr.columns is "<<arr.columns<<endl<<"columns is "<<columns<<endl<<endl;
                }
            }
        }
        return new_matrix;
    }

int main()
{
    dymatrix a1;
    cin >> a1;  //Define the rows of the matrix
    cout << a1<<endl<<endl;
    dymatrix a2;
    cin >> a2;
    cout << a2<<endl<<endl;
    dymatrix resu_a3;
    resu_a3 = a1*a2;
    cout<<"Multiplication = "<<resu_a3<<endl;
    return 0;
}
马丁·J。

在您的乘法运算符代码中,此行是错误的:

new_matrix.matrix[index(j,i)]= new_matrix.matrix[index(j,i)]+ matrix[index(j,k)]*arr(k,i);

问题是那index(j,i)真的是this->index(j,i),而不是new_matrix.index(j,i)您所期望的...

您应该将其替换为以下内容:

new_matrix(j,i) += matrix[index(j,k)]*arr(k,i);

但是真正的问题是:您有充分的理由要实现自己的矩阵类,而不是使用经过试验验证的矩阵库(例如Armadillo)吗?

本文收集自互联网,转载请注明来源。

如有侵权,请联系[email protected] 删除。

编辑于
0

我来说两句

0条评论
登录后参与评论

相关文章

来自分类Dev

乘法运算符重载

来自分类Dev

有关C ++运算符重载的问题

来自分类Dev

尝试对矩阵重载*运算符

来自分类Dev

运算符重载 + 动态矩阵

来自分类Dev

矩阵乘法哪一个更好?GLM的重载*运算符或直接使用着色器

来自分类Dev

矩阵乘法哪一个更好?GLM的重载*运算符或直接使用着色器

来自分类Dev

内联和运算符重载问题

来自分类Dev

C ++运算符重载性能问题

来自分类Dev

链表运算符重载问题

来自分类Dev

运算符重载问题C ++

来自分类Dev

C ++:运算符重载问题?

来自分类Dev

OpenACC 中的运算符重载问题

来自分类Dev

(C++) 重载“>>”运算符的问题

来自分类Dev

具有自定义标量类型的特征:自定义类型的矩阵乘法因“使用重载运算符'*'不明确”而失败。

来自分类Dev

为什么我的重载乘法运算符无法识别?

来自分类Dev

不使用模板即可重载乘法运算符

来自分类Dev

不使用模板即可重载乘法运算符

来自分类Dev

Swift-运算符重载-CGFloat的乘法

来自分类Dev

在模板类数组中重载乘法运算符

来自分类Dev

Typescript是否有运算符重载?

来自分类Dev

带有运算符重载的字典

来自分类Dev

乘法运算符

来自分类Dev

在不同类的运算符重载中访问/更改私有变量的问题

来自分类Dev

重载<<运算符

来自分类Dev

重载<<运算符

来自分类Dev

重载'-'运算符

来自分类Dev

*运算符重载

来自分类Dev

()运算符重载

来自分类Dev

运算符重载