我从事Python编程已有一年多了,而我刚回到C ++,学习了一些基本算法。我从合并排序开始,但是它给了我一个细分错误。帮助将不胜感激。我想我已经调试了发生的地方,但是我不明白为什么。
#include <iostream>
using namespace std;
void* merge(int array1[], int array2[], int low, int mid, int high){
int i, j, k;
for (i = low,j = mid, k = low; i < mid, j < high; k++){
if (array1[i] < array1[j]){
array2[k] = array1[i];
i++;
}
else{
array2[k] = array1[j];
j++;
}
}
if (i == mid){
for (; j < high; j++, k++){
array2[k] = array1[j];
}
}
else{
for (; i < mid; i++, k++){
array2[k] = array1[i];
}
}
void* merge_sort(int array1[], int copy[], int low, int high){
int mid;
int range = high - low;
if (range == 1)
copy[low] = array1[low];
else{
mid = low + range/2;
merge_sort(array1, copy, low, mid);
// Segmentation error seems to be here.
merge_sort(array1, copy, mid, high);
}
merge(array1, copy, low, mid, high);
}
int main()
{
int n, temp;
cout << "How many numbers do you want to enter?" << endl;
cin >> n;
int numarray[n];
for (int i = 0; i < n; i++){
cin >> numarray[i];
}
int dumarray[n]; // Used for filling elements from merge sort
merge_sort(numarray, dumarray, 0, n);
cout << "Merge Sort" << endl;
for (int i = 0; i < n; i++){
cout << dumarray[i] << endl;
}
return 0;
}
编辑:
#include <iostream>
using namespace std;
void merge_sort(int [], int [], int, int);
void merge(int array1[], int array2[], int low, int mid, int high){
int i, j, k;
for (i = low,j = mid, k = low; i < mid, j < high; k++){
if (array1[i] < array1[j]){
array2[k] = array1[i];
i++;
}
else{
array2[k] = array1[j];
j++;
}
}
if (i == mid){
for (; j < high; j++, k++){
array2[k] = array1[j];
}
}
else{
for (; i < mid; i++, k++){
array2[k] = array1[i];
}
}
}
void merge_sort(int array1[], int copy[], int low, int high){
int mid;
int range = high - low;
mid = low + range/2;
if (range == 1)
copy[low] = array1[low];
else{
mid = low + range/2;
merge_sort(array1, copy, low, mid);
merge_sort(array1, copy, mid, high);
merge(array1, copy, low, mid, high);
}
}
int main(){
int n, temp;
cout << "How many numbers do you want to enter?" << endl;
cin >> n;
int numarray[n];
for (int i = 0; i < n; i++){
cin >> numarray[i];
}
int dumarray[n];
merge_sort(numarray, dumarray ,0, n);
for (int i = 0; i < n; i++){
cout << dumarray[i] << endl;
}
}
中值的计算似乎是错误的。尝试计算为
mid = low + (high-low)/2
编辑:merge(array1, copy, low, mid, high);
在else括号内移动。
else
{
mid = low + range/2;
merge_sort(array1, copy, low, mid);
merge_sort(array1, copy, mid, high);
merge(array1, copy, low, mid, high);
}
该merge
功能也有很多错误。初始for循环中的条件检查i < mid, j < high
由逗号分隔,这意味着它仅检查j < high
i并舍弃了条件检查。
本文收集自互联网,转载请注明来源。
如有侵权,请联系[email protected] 删除。
我来说两句